Skip non-existent MBeans in JmxRecordSetProvider #24908
Merged
+51
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Feb 5, 2025
plugin/trino-jmx/src/main/java/io/trino/plugin/jmx/JmxRecordSetProvider.java
Outdated
Show resolved
Hide resolved
piotrrzysko
force-pushed
the
piotrrzysko/jmx-fix
branch
from
cac4d27 to
3e28e52
Compare
wendigo
reviewed
Feb 5, 2025
plugin/trino-jmx/src/test/java/io/trino/plugin/jmx/TestJmxSplitManager.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Feb 5, 2025
plugin/trino-jmx/src/test/java/io/trino/plugin/jmx/TestJmxSplitManager.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Feb 5, 2025
plugin/trino-jmx/src/test/java/io/trino/plugin/jmx/TestJmxSplitManager.java
Outdated
Show resolved
Hide resolved
When dynamic catalogs are enabled, and multiple catalogs use the same connector, querying a metric associated with the connector may return results only from the coordinator if not all catalogs have been used yet. This happens because the corresponding MBeans haven't been registered on the workers. With this change, the query will return results from workers for catalogs that have already been used and whose MBeans have been registered, while gracefully skipping non-existent MBeans.
piotrrzysko
force-pushed
the
piotrrzysko/jmx-fix
branch
from
3e28e52 to
7d3606e
Compare
wendigo
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When dynamic catalogs are enabled, and multiple catalogs use the same connector, querying a metric associated with the connector may return results only from the coordinator if not all catalogs have been used yet. This happens because the corresponding MBeans haven't been registered on the workers.
With this change, the query will return results from workers for catalogs that have already been used and whose MBeans have been registered, while gracefully skipping non-existent MBeans.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: