Make subschema constraint validation clearer

tristanpenman · Aug 24, 2023 · 0b7efb3 · 0b7efb3
1 parent 0530af0
commit 0b7efb3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/include/valijson/subschema.hpp b/include/valijson/subschema.hpp
@@ -120,7 +120,12 @@ class Subschema
     {
         bool allTrue = true;
         for (auto &&constraint : m_constraints) {
-            allTrue = applyFunction(*constraint) && allTrue;
+            // Even if an application fails, we want to continue checking the
+            // schema. In that case we set allTrue to false, and then fall
+            // through to the next constraint
+            if (!applyFunction(*constraint)) {
+                allTrue = false;
+            }
         }
 
         return allTrue;