Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add json schema for output file generation #364

Merged
merged 8 commits into from
Jul 27, 2023
Merged

add json schema for output file generation #364

merged 8 commits into from
Jul 27, 2023

Conversation

debermudez
Copy link
Contributor

Adds json schema file for new output file validation. This will work for both coupled and decoupled models.
Additionally, 2 example files are added to an examples directory.

Note: Json, being a data only format, does not allow comments. I do not know how to add a copyright to these files.

nv-hwoo
nv-hwoo reviewed Jul 21, 2023
View reviewed changes
src/c++/perf_analyzer/schema.json Outdated Show resolved Hide resolved
src/c++/perf_analyzer/schema.json Outdated Show resolved Hide resolved
tgerdesnv
tgerdesnv reviewed Jul 24, 2023
View reviewed changes
src/c++/perf_analyzer/schema.json Outdated Show resolved Hide resolved
src/c++/perf_analyzer/schema.json Outdated Show resolved Hide resolved
src/c++/perf_analyzer/schema.json Outdated
}
},
"window_boundaries": {
"description": "An array of time stamps describing window boundaries",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a word for the type of window? Is it an experiment window? Measurement window?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually thought this was the correct terminology. We discussed that these were called window boundaries when discussing this feature.

matthewkotila
matthewkotila reviewed Jul 26, 2023
View reviewed changes
src/c++/perf_analyzer/schema.json Outdated Show resolved Hide resolved
src/c++/perf_analyzer/schema.json Outdated Show resolved Hide resolved
src/c++/perf_analyzer/schema.json Outdated Show resolved Hide resolved
src/c++/perf_analyzer/schema.json Outdated Show resolved Hide resolved
src/c++/perf_analyzer/schema.json Show resolved Hide resolved
matthewkotila
matthewkotila approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@matthewkotila matthewkotila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I'd like merging to wait until @tgerdesnv has had a chance to respond/resolve his threads

@debermudez debermudez merged commit 2490073 into decoupled-model-support Jul 27, 2023
3 checks passed
@debermudez debermudez deleted the dbermudez-add-json-schema branch July 27, 2023 15:30
matthewkotila pushed a commit that referenced this pull request Jul 27, 2023
@debermudez @matthewkotila
add json schema for output file generation (#364)
203658e 
* Add json schema for output file and examples

* Add newlines at end of files

* Update json type to correct keyword

* Update schema to fix hierarchy and address feedback

* Add json file with known error for testing

* Move example files to the docs directory

* Remove some example json files

* Update schema to use integer and remove uniqueness from timestamps
matthewkotila pushed a commit that referenced this pull request Jul 28, 2023
@debermudez @matthewkotila
add json schema for output file generation (#364)
ba4f8a1 
* Add json schema for output file and examples

* Add newlines at end of files

* Update json type to correct keyword

* Update schema to fix hierarchy and address feedback

* Add json file with known error for testing

* Move example files to the docs directory

* Remove some example json files

* Update schema to use integer and remove uniqueness from timestamps
matthewkotila pushed a commit that referenced this pull request Jul 28, 2023
@debermudez @matthewkotila
add json schema for output file generation (#364)
2fa1c18 
* Add json schema for output file and examples

* Add newlines at end of files

* Update json type to correct keyword

* Update schema to fix hierarchy and address feedback

* Add json file with known error for testing

* Move example files to the docs directory

* Remove some example json files

* Update schema to use integer and remove uniqueness from timestamps
matthewkotila pushed a commit that referenced this pull request Aug 8, 2023
@debermudez @matthewkotila
add json schema for output file generation (#364)
0c12341 
* Add json schema for output file and examples

* Add newlines at end of files

* Update json type to correct keyword

* Update schema to fix hierarchy and address feedback

* Add json file with known error for testing

* Move example files to the docs directory

* Remove some example json files

* Update schema to use integer and remove uniqueness from timestamps
matthewkotila pushed a commit that referenced this pull request Aug 11, 2023
@debermudez @matthewkotila
add json schema for output file generation (#364)
98f95e0 
* Add json schema for output file and examples

* Add newlines at end of files

* Update json type to correct keyword

* Update schema to fix hierarchy and address feedback

* Add json file with known error for testing

* Move example files to the docs directory

* Remove some example json files

* Update schema to use integer and remove uniqueness from timestamps
matthewkotila pushed a commit that referenced this pull request Aug 15, 2023
@debermudez @matthewkotila
add json schema for output file generation (#364)
d663f94 
* Add json schema for output file and examples

* Add newlines at end of files

* Update json type to correct keyword

* Update schema to fix hierarchy and address feedback

* Add json file with known error for testing

* Move example files to the docs directory

* Remove some example json files

* Update schema to use integer and remove uniqueness from timestamps
matthewkotila added a commit that referenced this pull request Aug 15, 2023
@matthewkotila @debermudez
@tgerdesnv @nv-hwoo
Decoupled model support (#381)
6fbc18c 
* Update time stamp vector to hold a list of response times (#347)

* WIP change to timestamp vector

* Update testing to use new vector for end times

* Fix lambda and tag todo with a ticket number

* Fix iterator validation

* Update PA async callback to only run with final response (#351)

* Update PA async callback to only run with final response

* Address feedback

* Address feedback

* Address feedback

* Fix bug

* Calculate response throughput metric (#356)

* Calculate response throughput metric

* Address feedback

* Cleanup

* add json schema for output file generation (#364)

* Add json schema for output file and examples

* Add newlines at end of files

* Update json type to correct keyword

* Update schema to fix hierarchy and address feedback

* Add json file with known error for testing

* Move example files to the docs directory

* Remove some example json files

* Update schema to use integer and remove uniqueness from timestamps

* Add CLI option for profile export file (#369)

* Add CLI option for profile export file

* Address feedback

* Store sequence ID in timestamps tuple object (#367)

* Store sequence ID in timestamps tuple object

* Fix bug and address feedback

* Address feedback

* Address feedback

* Output response throughput metric to stdout and csv (#373)

* Add missing --profile-export-file help description and cli docs description (#374)

* create new json file output (#375)

* Initial commit to gather all experiment data

* Update response_timestamps variable name

* Revert erase_indices deletion

* Add reporter class to create json output

* Add comments to public methods

* Add file and stdout output

* Copy valid request records into RawDataCollector

* Plumb file path to reporter

* Connect collector to reporter

* Add json data to top level object

* Add experiments value to document

* Update json ints to uint64 and fix extry addition

* Print seq id only when non zero

* Moving schema to test repo

* Only write file if specified

* Address feedback

* Address feedback

---------

Co-authored-by: Matthew Kotila <[email protected]>
Co-authored-by: tgerdes <[email protected]>

* Fix bug where null response were accidentally excluded from profile export (#379)

* Fix bug where null response were accidentally excluded from profile export

* Fix bug

* Address feedback

* Add unit tests for ProfileDataCollector and ProfileDataExporter classes (#380)

* Add initial mock class and test file for ProfileDataCollector

* Mock FindExperiment method

* Add test for FindExperiment and fix a bug in the function

* Add tests for AddData and AddWindow in ProfileDataCollector

* Add a skeleton unit test code for ProfileDataExporter

* Mock ConvertToJson

* Add subcase for ConvertToJson method

* Add subcase for OutputToFile method

* Add subcase for AddExperiment method

* Split tests into multiple test cases

* Set request rate as double in json

* Address feedback

---------

Co-authored-by: Elias Bermudez <[email protected]>
Co-authored-by: tgerdes <[email protected]>
Co-authored-by: Hyunjae Woo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nv-hwoo nv-hwoo nv-hwoo left review comments

@tgerdesnv tgerdesnv tgerdesnv approved these changes

@matthewkotila matthewkotila matthewkotila approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debermudez @matthewkotila @tgerdesnv @nv-hwoo