Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sanity checking and error messages in PerfAnalyzer CLI #371

Merged
merged 11 commits into from
Aug 10, 2023
Merged

Improve sanity checking and error messages in PerfAnalyzer CLI #371

merged 11 commits into from
Aug 10, 2023

Commits on Aug 10, 2023

  1. Fix cli doc

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1a2b058 View commit details
    Browse the repository at this point in the history

  2. Validate CLI options that require non-negative input

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8baf84d View commit details
    Browse the repository at this point in the history

  3. Validate latency_thresold and max_trials

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    30a8b7b View commit details
    Browse the repository at this point in the history

  4. Validate more CLI options

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    fd6058a View commit details
    Browse the repository at this point in the history

  5. Validate sequence-id-range option

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    db0e0c5 View commit details
    Browse the repository at this point in the history

  6. Rename variables for better readability

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9b3f500 View commit details
    Browse the repository at this point in the history

  7. Catch invalid input arguments for all the options

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6faf0aa View commit details
    Browse the repository at this point in the history

  8. Combine cases that handle same option

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    28866ab View commit details
    Browse the repository at this point in the history

  9. Show flag in error message and a bit of refining

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    55d00a8 View commit details
    Browse the repository at this point in the history

  10. Set to default value when specified

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a85fff0 View commit details
    Browse the repository at this point in the history

  11. Address feedback

    @nv-hwoo
    nv-hwoo committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    abe684f View commit details
    Browse the repository at this point in the history