Ensure request body is always returned as bytes #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running tests |
|
Thanks for your contribution @willfrey. The tests passed. Can you fill the CLA as specified here: https://github.com/triton-inference-server/server/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla Also, cc: @Tabrizian, @tanmayv25 |
|
Hi @jbkyang-nvi. Sorry for the delay, I've been in the middle of a move overseas. I've emailed a signed copy of the CLA with corporate-related fields marked as N/A. If there's any issue with how I've filled out the form, please let me know. Thanks! |
|
Hi @willfrey did not get your email. Can you resend the email to [email protected]? |
|
@jbkyang-nvi I've resent it to the email you provided. |
|
CLA has been received and accepted. |
jbkyang-nvi
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
_get_inference_requestto always return the request body asbytes, as per theInferenceServerClient .generate_request_bodydocstring.Issues are disabled for this repository, so I apologize if it isn't appropriate to open PRs here!