Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in the CLI unit tests #377

Merged
merged 13 commits into from
Aug 15, 2023
Merged

Fix bugs in the CLI unit tests #377

merged 13 commits into from
Aug 15, 2023

Conversation

nv-hwoo
Copy link
Contributor

@nv-hwoo nv-hwoo commented Aug 7, 2023

  • Address "BUG" & "QUESTION" comments in test_command_line_parser.cc
  • Throw PA exception instead of exiting the program to match the behavior of test to behavior of production code

@nv-hwoo nv-hwoo requested review from debermudez, matthewkotila and tgerdesnv and removed request for debermudez August 7, 2023 15:27
Base automatically changed from hwoo-validate-cli-options to main August 10, 2023 23:29
@matthewkotila
Copy link
Contributor

Looks great overall! Thanks for working on this! 🙏

@nv-hwoo nv-hwoo merged commit c02ef4e into main Aug 15, 2023
3 checks passed
@nv-hwoo nv-hwoo deleted the hwoo-fix-cli-bug branch August 15, 2023 17:02
nv-hwoo added a commit that referenced this pull request Aug 16, 2023
nv-hwoo added a commit that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants