Throw exception when request period larger than max tokens rather than infinite loop #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkotila
force-pushed
the
matthewkotila-periodic-fix
branch
from
f116031
to
c49b056
Compare
matthewkotila
force-pushed
the
matthewkotila-periodic-fix
branch
from
c49b056
to
d36a4c8
Compare
nv-hwoo
reviewed
Sep 28, 2023
matthewkotila
added a commit
that referenced
this pull request
Oct 7, 2023
…n infinite loop (#403) * Throw exception when request period larger than max tokens rather than infinite loop * Update periodic_concurrency_worker.cc
matthewkotila
added a commit
that referenced
this pull request
Oct 7, 2023
…n infinite loop (#403) * Throw exception when request period larger than max tokens rather than infinite loop * Update periodic_concurrency_worker.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches when request receives final response without having first reached the end of the request period. Throws error with suggested solution to avoid infinite loop. User error. User must provide request period less than or equal to the max tokens the model will return per request.