Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Impact PA Migration Changes #722

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

fpetrini15
Copy link
Contributor

@fpetrini15 fpetrini15 commented Jun 27, 2024

Goal: Create a PR that contains the minimum number of changes necessary to validate the PA migration.

Server changes: triton-inference-server/server#7449

src/python/library/setup.py Dismissed Show resolved Hide resolved
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar work, Francesco! Left two questions. Also, please don't forget to address the CodeQL warning when you get a chance.

CMakeLists.txt Show resolved Hide resolved
src/c++/library/CMakeLists.txt Show resolved Hide resolved
@fpetrini15 fpetrini15 merged commit 86a0d09 into main Jul 29, 2024
5 checks passed
@fpetrini15 fpetrini15 deleted the fpetrini-migration-min branch July 29, 2024 16:15
dyastremsky pushed a commit that referenced this pull request Jul 29, 2024
Migrate PA Repo w/ Minimum Client changes.

Add typing
dyastremsky pushed a commit that referenced this pull request Jul 29, 2024
Migrate PA Repo w/ Minimum Client changes.

Add typing

Remove unused functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants