When custom profile export provided, update CSV/JSON naming #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove print Update docs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dyastremsky
force-pushed
the
dyas-csv-naming
branch
from
b59a15c
to
c020b0e
Compare
Migrate PA Repo w/ Minimum Client changes. Add typing Remove unused functions
dyastremsky
force-pushed
the
dyas-csv-naming
branch
from
0e8b741
to
dffe0cd
Compare
debermudez
approved these changes
Jul 29, 2024
nv-hwoo
reviewed
Jul 29, 2024
src/c++/perf_analyzer/genai-perf/genai_perf/export_data/csv_exporter.py
Outdated
Show resolved
Hide resolved
src/c++/perf_analyzer/genai-perf/genai_perf/export_data/json_exporter.py
Outdated
Show resolved
Hide resolved
| @@ -125,6 +131,9 @@ | |||
| Collect LLM metrics from profile export data and confirm correct values are | |||
| printed in csv. | |||
| """ | |||
| artifacts_dir = "artifacts/model_name-openai-chat-concurrency1" | |||
Check notice
Code scanning / CodeQL
Unused local variable Note test
Run pre-commit hooks
dyastremsky
force-pushed
the
dyas-csv-naming
branch
from
4ebde3e
to
06a601c
Compare
|
Closing in favor of triton-inference-server/perf_analyzer#19. With the PA migration started, changes should only be merged in that repo. CC: @fpetrini15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --profile-export-name is passed, the JSON and CSV names should use the profile export name. For example, if the name is "custom_name.json", the GenAI-Perf output files should be "custom_name_genai_perf.json" and "custom_name_genai_perf.csv". Fix this behavior and add testing.
Before:
After:
