Remove unnecessary linking of CUDA Runtime library #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyastremsky
approved these changes
Oct 24, 2024
fpetrini15
added a commit
that referenced
this pull request
Oct 25, 2024
This reverts commit 51a5e91.
matthewkotila
added a commit
that referenced
this pull request
Oct 25, 2024
This reverts commit 51a5e91.
fpetrini15
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Triton C++ client libraries do not actually use symbols in the CUDA Runtime library (
libcudart.so).So there's no need to
target_link_libraries()toCUDA::cudart.All they needed was access to
#include <cuda_runtime_api.h>(which was implicitly being included by doingtarget_link_libraries()).So I removed the
target_link_libraries ()s and addedtarget_include_directories()s.