Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variable causing L0_build_variants--build to fail. #404

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Unused variable causing L0_build_variants--build to fail. #404

merged 3 commits into from
Oct 30, 2024

Conversation

indrajit96
Copy link
Contributor

Unused variable in case of TRITON_ENABLE_METRICS set to OFF causing build failure here
https://gitlab-master.nvidia.com/dl/dgx/tritonserver/-/jobs/117883872

New Pipeline in progress

https://gitlab-master.nvidia.com/dl/dgx/tritonserver/-/pipelines/19741134

@yinggeh
Copy link
Contributor

yinggeh commented Oct 25, 2024 •
edited
Loading

I wonder when you built locally with -DTRITON_ENABLE_METRICS=OFF, did you see error or just warning?

@indrajit96
Copy link
Contributor Author

I wonder when you built locally with -DTRITON_ENABLE_METRICS=OFF, did you see error or just warning?

I just checked with -DTRITON_ENABLE_METRICS=OFF TRITON_ENABLE_METRICS_CPU=OFF TRITON_ENABLE_METRICS_GPU=OFF the build does error out.
I think I missed running build with metrics OFF after the final refactor which caused this.

yinggeh
yinggeh approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@yinggeh yinggeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Make sure it passes the CI.

@rmccorm4
Copy link
Contributor

@indrajit96 is this good to go? Did it pass CI? Would be good to fix L0_build_variants on nightlies

@indrajit96
Copy link
Contributor Author

@indrajit96 is this good to go? Did it pass CI? Would be good to fix L0_build_variants on nightlies

https://gitlab-master.nvidia.com/dl/dgx/tritonserver/-/jobs/118904982
Was triggered by @KrishnanPrash
Test passes.
Merging.

@indrajit96 indrajit96 merged commit 824bca9 into main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinggeh yinggeh yinggeh approved these changes

@rmccorm4 rmccorm4 rmccorm4 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@indrajit96 @yinggeh @rmccorm4