Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix L0_build_variants--build #410

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: Fix L0_build_variants--build #410

merged 1 commit into from
Nov 13, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Nov 13, 2024 •
edited
Loading

What does the PR do?

Fix build error when -DTRITON_ENABLE_METRICS=OFF.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • fix

Related PRs:

Where should the reviewer start?

Test plan:

L0_metrics--base
L0_model_config--base
L0_build_variants--build

  • CI Pipeline ID:
    20337448

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh added the bug Something isn't working label Nov 13, 2024
@yinggeh yinggeh self-assigned this Nov 13, 2024
rmccorm4
rmccorm4 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix🙏

@yinggeh yinggeh changed the title fix: Fix L0_build_variants fix: Fix L0_build_variants--build Nov 13, 2024
@yinggeh yinggeh merged commit 1c73674 into main Nov 13, 2024
1 check passed
yinggeh added a commit that referenced this pull request Nov 14, 2024
@yinggeh
fix: Fix L0_build_variants--build #410 (#412)
b8a4e5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

Assignees

@yinggeh yinggeh

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinggeh @rmccorm4