feat: Windows utf-16 Paths #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-nv
approved these changes
Jan 9, 2025
fpetrini15
force-pushed
the
fpetrini-akarale-win-utf16
branch
from
b3b50e9 to
0b74698
Compare
nv-kmcgill53
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting Ashish's changes from: #422 here.
Triton core server does not currently support paths that contain special unicode characters. This PR aims to fix this by decoding the paths just before use to a "std::wstring" and pass it to the relevant UTF16 supporting variants of functions being used in the core.