Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate request correlation ID data type #425

Merged
merged 4 commits into from
Jan 8, 2025
Merged

fix: Validate request correlation ID data type #425

merged 4 commits into from
Jan 8, 2025

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Jan 7, 2025 •
edited
Loading

What does the PR do?

  1. Validate request correlation ID data type.
  2. Allocate the correct size of request correlation ID to bypass Python backend ValidateStringBuffer().

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • fix

Related PRs:

triton-inference-server/server#7919

Where should the reviewer start?

Test plan:

  • L0_sequence_corrid_batcher

  • CI Pipeline ID:
    22217066

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh
1. Allocate correct byte size for CORRID string
fa343be 
2. Validate CORRID dtype matches override value dtype
@yinggeh yinggeh added the bug Something isn't working label Jan 7, 2025
@yinggeh yinggeh self-assigned this Jan 7, 2025
@yinggeh yinggeh mentioned this pull request Jan 7, 2025
Merged
11 tasks
@yinggeh yinggeh changed the title fix: Validate correlation ID data type fix: Validate request correlation ID data type Jan 7, 2025
@rmccorm4 rmccorm4 requested review from kthui and rmccorm4 January 7, 2025 22:31
rmccorm4
rmccorm4 reviewed Jan 7, 2025
View reviewed changes
src/infer_request.cc Outdated Show resolved Hide resolved
rmccorm4
rmccorm4 reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than function name change

@yinggeh yinggeh requested a review from rmccorm4 January 8, 2025 07:16
rmccorm4
rmccorm4 previously approved these changes Jan 8, 2025
View reviewed changes
@rmccorm4
Copy link
Contributor

rmccorm4 commented Jan 8, 2025

Please update to 2025 copyrights too

@yinggeh yinggeh requested a review from rmccorm4 January 8, 2025 18:40
@yinggeh yinggeh merged commit eeb283a into main Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@kthui kthui Awaiting requested review from kthui

Assignees

@yinggeh yinggeh

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinggeh @rmccorm4