Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception if remote server is not in explicit mode #754

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

nv-braf
Copy link
Contributor

@nv-braf nv-braf commented Aug 28, 2023

The current behavior is that we print an info message to the user when the model fails to load, but in this specific case we should immediately terminate MA and tell the user exactly what is wrong.

There is no API call to determine what mode the server is in, so I'm string matching on the relevant part of the exception message being returned.

Copy link
Contributor

@nv-hwoo nv-hwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nv-braf nv-braf merged commit d708869 into main Aug 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants