Move configuration checks to converters #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyastremsky
added a commit
that referenced
this pull request
Oct 16, 2024
dyastremsky
added a commit
that referenced
this pull request
Oct 19, 2024
…140) * Create Generic Dataset (#124) * hook up synthetic retriever to the new factory (#125) * Remove dataset-format-transformer since it is no longer necessary (#127) * Update type from Dict to add details (#129) * Add multi-file support in retriever (#128) * Add client-side batching for synthetic (#133) * Add remaining converters, clean up retriever factory (#135) * Move configuration checks to converters (#136) * Add multi-file support for synthetic (#137) * Support client-side batching for legacy completions endpoint (#138) * Allow image retrieval endpoint to use synthetic data (#139) * Update unit tests after GenericDataset redesign (#142) --------- Co-authored-by: Elias Bermudez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the converter-specific configuration checks to the converters. Pull the converter creation earlier in the inputs generation process to check the config before generating the input data.