Add authentication instructions to GenAI-Perf tutorial #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyastremsky
changed the title
nv-braf
reviewed
Nov 7, 2024
genai-perf/docs/tutorial.md
Outdated
| @@ -163,6 +163,17 @@ Example output: | |||
| └───────────────────────────────────┴──────────┴──────────┴──────────┴──────────┴──────────┴──────────┘ | |||
| ``` | |||
|
|
|||
| ### Running with Authentication | |||
| GenAI-Perf can benchmark secure endpoints such as OpenAI, which requires API | |||
| key authentication. To do so, you can add your API key directly in the command. | |||
There was a problem hiding this comment.
Nice suggestion, updated!
genai-perf/docs/tutorial.md
Outdated
|
|
||
| ### Running with Authentication | ||
| GenAI-Perf can benchmark secure endpoints such as OpenAI, which requires API | ||
| key authentication. To do so, you can add your API key directly in the command. |
There was a problem hiding this comment.
Nice suggestion, updated.
| @@ -163,6 +163,17 @@ Example output: | |||
| └───────────────────────────────────┴──────────┴──────────┴──────────┴──────────┴──────────┴──────────┘ | |||
| ``` | |||
|
|
|||
| ### Running with Authentication | |||
| GenAI-Perf can benchmark secure endpoints such as OpenAI, which requires API | |||
| key authentication. To do so, you can add your API key directly in the command. | |||
| @@ -201,3 +212,13 @@ Example output: | |||
| └───────────────────────────────────┴────────┴────────┴────────┴────────┴────────┴────────┘ | |||
| ``` | |||
|
|
|||
| ### Running with Authentication | |||
| GenAI-Perf can benchmark secure endpoints such as OpenAI, which requires API | |||
| key authentication. To do so, you can add your API key directly in the command. | |||
nv-hwoo
reviewed
Nov 7, 2024
Use plural verb
dyastremsky
force-pushed
the
dyas-authentication
branch
from
0971685
to
10a0fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions for benchmarking an actual OpenAI endpoint or any endpoint requiring authentication to the GenAI-Perf tutorial. This can be done by passing the token in via the HTTP headers.