-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code analysis hooks #20
Conversation
56bfd2c
to
59df748
Compare
Fix configs Fix configs
59df748
to
e9d91d7
Compare
Can we add those rules? |
@debermudez Yes, I'm working with Meenakshi to get those rules in this place for this repo as well. |
@nvda-mesharma any word on the security rule here? Can we merge anyways? These changes must be in place before code freeze in order to align with the doc changes I have. |
@nvda-mesharma We'd really like to get this merged in. If we need to, we can merge it with CodeQL failing for now, but ideally we'd get the automated checks here to match those as our other repos. It says advanced security needs to be enabled (perhaps it just needs to be open-sourced? we didn't need to do anything extra for our other repos, unless there is a setting difference here). CC: @ganeshku1 |
Based on offline discussion, we are merging this. CodeQL should work once the repo is open-sourced. |
Migrate precommit, CodeQL, and unit test hooks to Perf Analyzer repo. We may want to add rules to require these to pass before merging. We had those in the client repo.