Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vscode configurations to make development easier #352

Merged
merged 10 commits into from
Apr 16, 2024
Merged

Add vscode configurations to make development easier #352

merged 10 commits into from
Apr 16, 2024

Conversation

Tabrizian
Copy link
Member

Now you can start development on Python backend just by cloning the folder and using dev container.

Some tasks are added for configuration and build.

fpetrini15
fpetrini15 reviewed Apr 16, 2024
View reviewed changes
.vscode/tasks.json Outdated Show resolved Hide resolved
@fpetrini15 fpetrini15 self-requested a review April 16, 2024 21:16
fpetrini15
fpetrini15 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@fpetrini15 fpetrini15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a new build and was able to build the python backend successfully. Optional nit.

Beyond that, LGTM! 🚀

krishung5
krishung5 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@krishung5 krishung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that I can also build the backend locally without issues. Thanks Iman, nice improvement!

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
@fpetrini15
Copy link
Contributor

Rebuilt with the new changes (works!) but noticed this time around that we get a warning that "TRITON_ENABLE_ENSEMBLE" is unused.

fpetrini15
fpetrini15 requested changes Apr 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Tabrizian
Copy link
Member Author

Rebuilt with the new changes (works!) but noticed this time around that we get a warning that "TRITON_ENABLE_ENSEMBLE" is unused.

I removed the unused cmake variables.

@fpetrini15 fpetrini15 self-requested a review April 16, 2024 22:08
fpetrini15
fpetrini15 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@fpetrini15 fpetrini15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tabrizian Tabrizian merged commit b7a0690 into main Apr 16, 2024
3 checks passed
@Tabrizian Tabrizian deleted the imant-vscode branch April 16, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishung5 krishung5 krishung5 approved these changes

@fpetrini15 fpetrini15 fpetrini15 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tabrizian @fpetrini15 @krishung5