Add error handling in case of AutocompleteStub Failure for DLIS-5819 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmayv25
reviewed
May 4, 2024
Tabrizian
requested changes
May 6, 2024
krishung5
reviewed
May 8, 2024
tanmayv25
approved these changes
May 8, 2024
rmccorm4
reviewed
May 8, 2024
krishung5
approved these changes
May 8, 2024
indrajit96
added a commit
that referenced
this pull request
May 9, 2024
…356) * DLIS-5819 * Guard WaitForStubProcess in case of failed auto-complete-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested various failures in Load/Unload API
Handling for error in LaunchAutoCompleteStubProcess() was not complete causing the HTTP request to hang, in case of faulty autocomplete function.
Attached new behaviour in the image
Followup question:
I saw similar handling in ALL other backends as well, I think a fix would be needed in all of them.