Skip to content

Commit

Permalink
Fixed missing install script for NeMo example
Browse files Browse the repository at this point in the history
  • Loading branch information
jkosek committed Apr 26, 2024
1 parent 5f18f6e commit 627e7a9
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ limitations under the License.

# Changelog

## unreleased
- Change: limited the `tritonclient` pacakge extras to http and grpc only

## 0.5.5 (2024-04-15)

- Fix: Performance improvements
Expand Down
16 changes: 16 additions & 0 deletions examples/nemo_megatron_gpt_multinode/install.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/bin/bash
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
set -xe
pip3 install "huggingface-hub>=0.13" "numpy==1.22"
7 changes: 7 additions & 0 deletions tests/functional/L0_example_nemo_megatron_gpt/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@ def main():
elapsed_s = 0
wait_time_s = min(args.timeout_s, 1)

install_cmd = ["bash", "examples/nemo_megatron_gpt_multinode/install.sh"]
with ScriptThread(install_cmd, name="install") as install_thread:
install_thread.join()

if install_thread.returncode != 0:
raise RuntimeError(f"Install thread returned {install_thread.returncode}")

server_cmd = ["python", "examples/nemo_megatron_gpt_multinode/server.py"]
client_cmd = [
"python",
Expand Down
3 changes: 0 additions & 3 deletions tests/functional/L0_example_nemo_megatron_gpt/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ set -xe
THIS_SCRIPT_DIR="$(realpath --relative-to="${PWD}" "$(dirname "$0")")"
TEST_MODULE="${THIS_SCRIPT_DIR//\//.}.test"

# nemo-toolkit 1.20.0 requires numpy<1.24,>=1.22, numba crashes with never version
pip install "numpy==1.22"

# This is necessary to avoid error in ONNX used my NeMo toolkit for version of protobuf never than 3.7
export PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python

Expand Down

0 comments on commit 627e7a9

Please sign in to comment.