Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify path for PyTorch model extension library #7025

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Mar 22, 2024

No description provided.

@mc-nv mc-nv requested a review from nv-kmcgill53 March 22, 2024 20:36
@nv-kmcgill53
Copy link
Contributor

Is the pyTorch team adding this back to their containers? I thought they were not going to be shipping this because it was a mistake.

@mc-nv
Copy link
Contributor Author

mc-nv commented Mar 22, 2024

Is the pyTorch team adding this back to their containers? I thought they were not going to be shipping this because it was a mistake.

I made a mistake by removing it, looks I mistype path for custom_modulo ins cript.
By default path is autogenerated unless variable is provided.

I went into code and found that we can gain control over it.
https://github.com/pytorch/pytorch/blob/main/torch/utils/cpp_extension.py#L2032-L2045

@mc-nv mc-nv merged commit 1441f45 into r24.03 Mar 26, 2024
3 checks passed
@mc-nv mc-nv deleted the mchornyi-custom-ops branch March 26, 2024 19:00
mc-nv added a commit that referenced this pull request Apr 1, 2024
* Update README and versions for 2.44.0 / 24.03 (#6971)

* Update README and versions for 2.44.0 / 24.03

* Mchornyi 24.03 (#6972)

* Current location is dropped in 12.4

* Update Dockerfile.win10.min

* Change to triton_sample_folder (#6973)

---------

Co-authored-by: kyle <[email protected]>
Co-authored-by: Misha Chornyi <[email protected]>

* Specify path for PyTorch model extension library (#7025)

* Update README.md 2.44.0 / 24.03 (#7032)

* Update README.md post-24.03

---------

Co-authored-by: Kyle McGill <[email protected]>
Co-authored-by: kyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants