Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for improper response sending from model #7292

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented May 29, 2024

Previous PRs:

Related PR: triton-inference-server/python_backend#363

Add tests for decoupled models using the response_sender and returning a response.
Add tests for non-decoupled models sending multiple responses, using the response_sender and/or returning a response.

@kthui kthui marked this pull request as ready for review May 29, 2024 17:07
@kthui kthui requested a review from Tabrizian May 29, 2024 17:07
@kthui kthui force-pushed the jacky-res-sender-test-bad-model branch from 18336fd to a06e090 Compare May 30, 2024 07:30
@kthui kthui force-pushed the jacky-res-sender-test-bad-model branch from a06e090 to 81a2e35 Compare May 30, 2024 22:48
Copy link
Member

@Tabrizian Tabrizian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions, fantastic test coverage! Thanks Jacky 🙇

@kthui
Copy link
Contributor Author

kthui commented May 31, 2024

@kthui kthui force-pushed the jacky-res-sender-test-bad-model branch from 1789adb to e38ecfe Compare May 31, 2024 23:11
@kthui kthui requested a review from Tabrizian June 1, 2024 00:19
@kthui kthui merged commit 740ef3e into jacky-res-sender-main Jun 4, 2024
3 checks passed
@kthui kthui deleted the jacky-res-sender-test-bad-model branch June 4, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants