-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for improper response sending from model #7292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2024
kthui
force-pushed
the
jacky-res-sender-test-bad-model
branch
from
May 30, 2024 07:30
18336fd
to
a06e090
Compare
kthui
force-pushed
the
jacky-res-sender-test-bad-model
branch
from
May 30, 2024 22:48
a06e090
to
81a2e35
Compare
kthui
force-pushed
the
jacky-res-sender-test-bad-model
branch
from
May 31, 2024 00:09
81a2e35
to
0f847d5
Compare
kthui
force-pushed
the
jacky-res-sender-test-bad-model
branch
from
May 31, 2024 01:02
0f847d5
to
1789adb
Compare
Tabrizian
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor questions, fantastic test coverage! Thanks Jacky 🙇
…al flag separately
Rebased onto https://github.com/triton-inference-server/server/tree/jacky-res-sender-main for merging. |
kthui
force-pushed
the
jacky-res-sender-test-bad-model
branch
from
May 31, 2024 23:11
1789adb
to
e38ecfe
Compare
Tabrizian
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PRs:
Related PR: triton-inference-server/python_backend#363
Add tests for decoupled models using the
response_sender
and returning a response.Add tests for non-decoupled models sending multiple responses, using the
response_sender
and/or returning a response.