Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: Added gRPC timer for graceful shutdown of inflight requests #7835

Closed
wants to merge 3,468 commits into from

Conversation

mattwittwer
Copy link

What does the PR do?

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

mc-nv and others added 30 commits January 12, 2024 14:33
Added support for OTel context propagation

---------

Co-authored-by: Markus Hennerbichler <[email protected]>
Co-authored-by: Ryan McCormick <[email protected]>
This validates the change made to ../core wrt how model configuration mtime is handled.
* Run all cases wihh shm probe

* Warmup test and then run multiple iterations

* Log free shared memory on enter/exit of probe

* Add shm probe to all tests

* Add debug_str to shm_util

* Refactor ensemble_io test, modify probe to check for growth rather than inequality

* Improve stability of bls_tensor_lifecycle gpu memory tests

* Add more visibility into failing model/case in python_unittest helper

* [FIXME] Skip probe on certain subtests for now

* [FIXME] Remove shm probe from test_restart on unhealthy stub

* Start clean server run for each bls test case

* Don't exit early on failure so logs can be properly collected

* Restore bls test logic

* Fix shm size compare

* Print region name that leaked

* Remove special handling on unittest

* Remove debug str

* Add enter and exit delay to shm leak probe

---------

Co-authored-by: Ryan McCormick <[email protected]>
* Update trace_summery script

* Remove GRPC_WAITREAD and Overhead
* Add gsutil cp retry helper function

* Add max retry to GCS upload

* Use simple sequential upload
* Handle empty output

* Add test case for 0 dimension output

* Fix up number of tests
* tensorrt-llm benchmarking test
* Update README and versions for 2.42.0 / 24.01 (#6789)

* Update versions

* Update README and versions for 2.42.0 / 24.01

* Fix documentaation genarion (#6801)

* Ser version of sphix to 5.0

* Set verions 5.0.0

* Update README.md and versions post 24.01
…und (#6834)

* Update miniconda version

* Install pytest for different py version

* Install pytest
* Add test for shutdown while loading

* Fix intermittent failure on test_model_config_overwrite
Adding OpenTelemetry Batch Span Processor
---------

Co-authored-by: Theo Clark <[email protected]>
Co-authored-by: Ryan McCormick <[email protected]>
* Support Double-Type Infer/Response Parameters
* Base Python Backend Support for Windows
* Add unit test reports to L0_dlpack_multi_gpu

* Add unit test reports to L0_warmup
* Add response statistics

* Add L0_response_statistics

* Enable http vs grpc statistics comparison

* Add docs for response statistics protocol

* Add more comments for response statistics test

* Remove model name from config

* Improve docs wordings

* [Continue] Improve docs wordings

* [Continue] Add more comments for response statistics test

* [Continue 2] Improve docs wordings

* Fix typo

* Remove mentioning decoupled from docs

* [Continue 3] Improve docs wordings

* [Continue 4] Improve docs wordings

Co-authored-by: Ryan McCormick <[email protected]>

---------

Co-authored-by: Ryan McCormick <[email protected]>
* Switch to Python model for busyop test

* Clean up

* Address comment

* Remove unused import
KrishnanPrash and others added 18 commits November 4, 2024 14:15
…t version map to dictionary (#7500)

Co-authored-by: Olga Andreeva <[email protected]>
Co-authored-by: Kyle McGill <[email protected]>
@mattwittwer mattwittwer self-assigned this Nov 25, 2024
@statiraju statiraju requested a review from krishung5 January 6, 2025 19:17
@pvijayakrish pvijayakrish force-pushed the mwittwer/gRPC-endpoint-timeout branch from a238be0 to 32601bf Compare January 15, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.