Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enabled build behind proxy #7842

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: enabled build behind proxy #7842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1772,6 +1772,8 @@ def create_docker_build_script(script_name, container_install_dir, container_ci_
runargs += ["-v", "\\\\.\pipe\docker_engine:\\\\.\pipe\docker_engine"]
else:
runargs += ["-v", "/var/run/docker.sock:/var/run/docker.sock"]
if os.path.exists(os.path.expanduser("~/.docker/config.json")):
runargs += ["-v", os.path.expanduser("~/.docker/config.json:/root/.docker/config.json")]
Comment on lines +1775 to +1776
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this change.
It's kind of we allow to add something without validation.
We have no control of ~/.docker/config.json entries there why we may be forced to review some false positive issues related to user environment.

I may need a bit more context, sound like user looking for a proxy config during the build process, and I may be mistaken here but the issue happen when we run Docker-out-of-Docker configuration using build.py and user is behind the proxy.

I suppose it's better to add a flag for users --use-user-docker-config and add value accordingly if flag is given.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree a flag may be more appropriate here to be clear on the intent


runargs += ["tritonserver_buildbase"]

Expand Down