build: Dockerfiles generated by build.py for RHEL require base image specification #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test for shutdown while loading * Fix intermittent failure on test_model_config_overwrite
Adding OpenTelemetry Batch Span Processor --------- Co-authored-by: Theo Clark <[email protected]> Co-authored-by: Ryan McCormick <[email protected]>
* Support Double-Type Infer/Response Parameters
* Base Python Backend Support for Windows
* Add unit test reports to L0_dlpack_multi_gpu * Add unit test reports to L0_warmup
* Add response statistics * Add L0_response_statistics * Enable http vs grpc statistics comparison * Add docs for response statistics protocol * Add more comments for response statistics test * Remove model name from config * Improve docs wordings * [Continue] Improve docs wordings * [Continue] Add more comments for response statistics test * [Continue 2] Improve docs wordings * Fix typo * Remove mentioning decoupled from docs * [Continue 3] Improve docs wordings * [Continue 4] Improve docs wordings Co-authored-by: Ryan McCormick <[email protected]> --------- Co-authored-by: Ryan McCormick <[email protected]>
* Switch to Python model for busyop test * Clean up * Address comment * Remove unused import
* Add cancellation into response statistics * Add test for response statistics cancel * Remove debugging print * Use is None comparison * Fix docs * Use default args None * Refactor RegisterModelStatistics()
* Modify "header_forward_pattern" to match headers case-insensitively. Add unit tests. * fix indentation * fix pre-comiit errors * Update doc * Update copyright * Add test case for "(?-i)", which disables regex case-insensitive mode. * fix pre-commit * Name each test. Remove support of disabling --http-header-forward-pattern case-insensitive mode on http python client. * Update .md file. * fix typo * Reformat args. * Fix pre-commit * Fix test name issue. * Fix pre-commit. * Update md file and copyright.
* Update README and versions for 2.43.0 / 24.02 * Update Dockefile to reduce image size. * Update path in patch file for model generation Update README.md post-24.02
* patching git repository parameterization from production branch 1 * Fix go package directory name * pre-commit fixes * pre-commit fixes --------- Co-authored-by: kyle <[email protected]>
* Enhance bound check for shm offset * Add test for enhance bound check for shm offset * Fix off by 1 on max offset * Improve comments * Improve comment and offset * Separate logic between computation and validation
…6017) * Allow non-decoupled model to send response and FINAL flag separately * Update copyright * Defer sending error until FINAL flag is seen to avoid invalid reference * Move timestamp capture location * Delay time-point of response complete timestamp in GPRC and SageMaker endpoint * Move location of RESPONSE_COMPLETE timestamp capture to better align with the meaning.
Added a test case to check for optional/required input params in a request and appropriate response from server. Includes addition of 3 simple models with a combination of required/optional input params
Add flag to enable compile of OpenAI support in PA
* Test Correlation Id string support for BLS
* Add AsyncIO HTTP compression test * Improve command line option handling
…t version map to dictionary (#7500) Co-authored-by: Olga Andreeva <[email protected]> Co-authored-by: Kyle McGill <[email protected]>
Co-authored-by: GuanLuo <[email protected]>
Co-authored-by: Anant Sharma <[email protected]> Co-authored-by: Jacky <[email protected]> Co-authored-by: Kris Hung <[email protected]>
Co-authored-by: Kyle McGill <[email protected]>
Co-authored-by: Ryan McCormick <[email protected]>
Co-authored-by: Meenakshi Sharma <[email protected]> Co-authored-by: Kyle McGill <[email protected]>
saturley-hall
added
the
PR: build
saturley-hall
changed the title
fpetrini15
force-pushed
the
hsaturleyhal/tprd-806_rhel_without_base_image_errors_build-py
branch
from
5e05f4f to
baf2c09
Compare
pvijayakrish
force-pushed
the
hsaturleyhal/tprd-806_rhel_without_base_image_errors_build-py
branch
from
909d3e3 to
7b2f147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Images built for RHEL which did not specify a base image defaulted to Ubuntu 24.04 which caused error during the docker build stage as the
yumpackage manager was unavailable. This change causesbuild.pyto error out with a message should the RHEL target be specified without a base image also being specified.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Caveats:
Specification of a RHEL base image does not guarantee that the container will build as there are internal dependencies that may be missing.