Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use tracing crate #161

Merged
merged 1 commit into from
Feb 11, 2025
Merged

refactor: Use tracing crate #161

merged 1 commit into from
Feb 11, 2025

Conversation

grahamking
Copy link
Contributor

Previously we pretended it was the log crate, but they have subtly different interfaces. See #154

Previously we pretended it was the `log` crate, but they have subtly
different interfaces. See #154
Copy link
Contributor

@nv-anants nv-anants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grahamking grahamking merged commit a692cd2 into main Feb 11, 2025
6 checks passed
@grahamking grahamking deleted the gk-log-tracing branch February 11, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants