Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating with minor fixes and support for custom types #175

Merged
merged 7 commits into from
Feb 14, 2025

Conversation

nnshah1
Copy link
Collaborator

@nnshah1 nnshah1 commented Feb 13, 2025

What does the PR do?

  • Added test for iterator mode of subscription

  • Added default for event topic and event type

  • Added support for automatic serialization of typed that aren't bytes (using json)

  • Added support for retrieving payload as a type - json by default

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • [x ] Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@nnshah1 nnshah1 merged commit 8144c6a into bkubiak-eventplane Feb 14, 2025
5 checks passed
@nnshah1 nnshah1 deleted the nnshah1-eventplane branch February 14, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants