Update AutoScaling Blog to 24.07 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whoisj
requested changes
Sep 25, 2024
Deployment/Kubernetes/TensorRT-LLM_Autoscaling_and_Load_Balancing/chart/pvc/storageclass.yaml
Outdated
Show resolved
Hide resolved
| @@ -286,11 +283,14 @@ spec: | |||
| - name: engine-repository | |||
| hostPath: | |||
| path: {{ printf "%s/models/%s/%dx%d/engines" $hostRootPath $model_lower (int $model_pp) (int $model_tp) }} | |||
| type: DirectoryOrCreate | |||
| type: DirectoryOrCreate | |||
There was a problem hiding this comment.
extra, errant whitespace at end of line.
Deployment/Kubernetes/TensorRT-LLM_Autoscaling_and_Load_Balancing/chart/pvc/claim.yaml
Outdated
Show resolved
Hide resolved
| apiVersion: v1 | ||
| kind: PersistentVolume | ||
| metadata: | ||
| name: efs-autoscaling-pv-2 |
There was a problem hiding this comment.
we should pick a more meaningful, and less AWS specific name for this.
There was a problem hiding this comment.
Moved all pvc charts for aws under pvc_aws folder
Deployment/Kubernetes/TensorRT-LLM_Autoscaling_and_Load_Balancing/setup_ssh-efs.yaml
Outdated
Show resolved
Hide resolved
Deployment/Kubernetes/TensorRT-LLM_Autoscaling_and_Load_Balancing/containers/server.py
Show resolved
Hide resolved
whoisj
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update container file to point to 24.07 instead of 24.04
Update triton cli to point to 24.07 conversion scripts