Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vllm tutorial to use vllm based container from NGC #65

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

oandreeva-nv
Copy link
Collaborator

No description provided.

Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, Olga! Added some minor comments.

Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
dyastremsky
dyastremsky previously approved these changes Oct 31, 2023
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added optional comments aimed at improving readability.

Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Quick_Deploy/vLLM/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@oandreeva-nv oandreeva-nv merged commit 9a179ca into main Oct 31, 2023
3 checks passed
@oandreeva-nv oandreeva-nv deleted the oandreeva_vllm_container_tutorial branch October 31, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants