[AMD] MI350 support for ds_read_b64_tr_b8 instruction for int8 GEMMS #6018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
requested changes
Feb 25, 2025
plognjen
force-pushed
the
ds_trans_8bit
branch
from
d6caf10 to
64d4fea
Compare
antiagainst
requested changes
Feb 26, 2025
antiagainst
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only enable lowering to ds_read_b64_tr_b8 through int8 matrix multiplication.
The same instruction will be selected for fp8 types. However, due to the lack of support and tests for fp8 on the MI350 architecture, this PR limits transpose reads to int8 only.