Support creating int1 tensors in interpreter #6058
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jokeren
reviewed
Feb 28, 2025
|
|
||
| @pytest.mark.interpreter | ||
| @pytest.mark.parametrize("dtype", map(tl.dtype, tl.dtype.SINT_TYPES + tl.dtype.UINT_TYPES + tl.dtype.STANDARD_FP_TYPES)) | ||
| def test_dtypes(device, dtype): |
There was a problem hiding this comment.
You may want to differentiate this test with test_dtype. Either merge tests or change one of the function names.
There was a problem hiding this comment.
Ok, renamed it to test_dtype_tensor (willing to take suggestions on better names if you have any). I'm not entirely sure what test_dtype is supposed to do so I left it alone for now.
Jokeren
reviewed
Feb 28, 2025
| def test_dtype_tensor(device, dtype): | ||
|
|
||
| @triton.jit | ||
| def dtype_tensor_kernel(dtype): |
There was a problem hiding this comment.
Suggested change
| def dtype_tensor_kernel(dtype): | |
| def dtype_tensor_kernel(dtype: tl.constexpr): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)