Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable CFL EG Jeans #2089

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Stable CFL EG Jeans #2089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b62a4d6
Stable CFL EG Jeans
DanielDoehring Sep 26, 2024
ecdcbc3
comments
DanielDoehring Sep 26, 2024
6f9acc0
Merge branch 'main' into CFL_EG_Jeans
DanielDoehring Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/paper_self_gravitating_gas_dynamics/elixir_eulergravity_jeans_instability.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ semi_gravity = SemidiscretizationHyperbolic(mesh, equations_gravity, initial_con
# combining both semidiscretizations for Euler + self-gravity
parameters = ParametersEulerGravity(background_density = 1.5e7, # aka rho0
gravitational_constant = 6.674e-8, # aka G
cfl = 1.6,
cfl = 0.8, # value as used in the paper
resid_tol = 1.0e-4,
n_iterations_max = 1000,
timestep_gravity = timestep_gravity_carpenter_kennedy_erk54_2N!)
Expand All @@ -105,7 +105,7 @@ ode = semidiscretize(semi, tspan);

summary_callback = SummaryCallback()

stepsize_callback = StepsizeCallback(cfl = 1.0)
stepsize_callback = StepsizeCallback(cfl = 0.5) # value as used in the paper

save_solution = SaveSolutionCallback(interval = 10,
save_initial_solution = true,
Expand Down
24 changes: 12 additions & 12 deletions test/test_paper_self_gravitating_gas_dynamics.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,16 +215,16 @@ end
@test_trixi_include(joinpath(EXAMPLES_DIR,
"elixir_eulergravity_jeans_instability.jl"),
l2=[
10733.63378538114,
13356.780607423452,
10733.28239179182,
13356.0533511341,
1.6722844879795038e-6,
26834.076821148774
26833.19833691448
],
linf=[
15194.296424901113,
18881.481685044182,
15193.794080890715,
18880.45819785685,
6.809726988008751e-6,
37972.99700513482
37971.74113135785
],
tspan=(0.0, 0.1),
atol=4.0e-6)
Expand All @@ -242,16 +242,16 @@ end
@test_trixi_include(joinpath(EXAMPLES_DIR,
"elixir_eulergravity_jeans_instability.jl"),
l2=[
10734.598193238024,
13358.217234481384,
10734.653995035567,
13357.709699808021,
1.911011743371934e-6,
26836.487841241516
26836.62734552835
],
linf=[
15195.661004798487,
18883.512035906537,
15195.73481107317,
18882.799120551972,
7.867948710816926e-6,
37976.408478975296
37976.592992473394
],
tspan=(0.0, 0.1),
atol=4.0e-6, # the background field is reatively large, so this corresponds to our usual atol
Expand Down
Loading