Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat) #2091

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DiffEqCallbacks package from 2.25 to 2.25, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2024-09-28-00-05-01-101-01778587097 branch from 36fca4c to 85a4659 Compare September 28, 2024 00:05
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (0c2c367) to head (88884ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         470      470           
  Lines       37512    37512           
=======================================
  Hits        36140    36140           
  Misses       1372     1372           
Flag Coverage Δ
unittests 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member

sloede commented Sep 28, 2024

The tests pass, but then again, they seem to be using DiffEqCallbacks v2.37.0. Should we merge anyways?

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. We should wait until dependencies have been updated to test the new version.

@ranocha
Copy link
Member

ranocha commented Oct 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants