Skip to content

Commit

Permalink
update tolerances
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickersing committed Mar 11, 2024
1 parent 8553c2c commit 260782e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion test/test_tree_1d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ end
4.4541473087633676e-7,
],
tspan=(0.0, 0.05),
atol=3e-10) # see https://github.com/trixi-framework/Trixi.jl/issues/1617
atol=1e-7, rtol=1e-7) # see https://github.com/trixi-framework/Trixi.jl/issues/1617
# Ensure that we do not have excessive memory allocations
# (e.g., from type instabilities)
let
Expand Down
15 changes: 12 additions & 3 deletions test/test_unstructured_2d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ end
2.0246214978154587e-11,
1.513851228231574,
],
tspan=(0.0, 0.25))
tspan=(0.0, 0.25),
# Since we expect erros slighlty above machine precision, relative errors can

Check warning on line 58 in test/test_unstructured_2d.jl

View workflow job for this annotation

GitHub Actions / Spell Check with Typos

"erros" should be "errors".

Check warning on line 58 in test/test_unstructured_2d.jl

View workflow job for this annotation

GitHub Actions / Spell Check with Typos

"slighlty" should be "slightly".
# become very large
atol = 1e-10, rtol = 10)
# Ensure that we do not have excessive memory allocations
# (e.g., from type instabilities)
let
Expand Down Expand Up @@ -82,7 +85,10 @@ end
surface_flux=(FluxHydrostaticReconstruction(flux_lax_friedrichs,
hydrostatic_reconstruction_audusse_etal),
flux_nonconservative_audusse_etal),
tspan=(0.0, 0.2))
tspan=(0.0, 0.2),
# Since we expect erros slighlty above machine precision, relative errors can

Check warning on line 89 in test/test_unstructured_2d.jl

View workflow job for this annotation

GitHub Actions / Spell Check with Typos

"erros" should be "errors".

Check warning on line 89 in test/test_unstructured_2d.jl

View workflow job for this annotation

GitHub Actions / Spell Check with Typos

"slighlty" should be "slightly".
# become very large
atol = 1e-10, rtol = 10)
# Ensure that we do not have excessive memory allocations
# (e.g., from type instabilities)
let
Expand Down Expand Up @@ -111,7 +117,10 @@ end
flux_nonconservative_ersing_etal),
volume_flux=(flux_wintermeyer_etal,
flux_nonconservative_ersing_etal),
tspan=(0.0, 0.25))
tspan=(0.0, 0.25),
# Since we expect erros slighlty above machine precision, relative errors can

Check warning on line 121 in test/test_unstructured_2d.jl

View workflow job for this annotation

GitHub Actions / Spell Check with Typos

"erros" should be "errors".

Check warning on line 121 in test/test_unstructured_2d.jl

View workflow job for this annotation

GitHub Actions / Spell Check with Typos

"slighlty" should be "slightly".
# become very large
atol = 1e-10, rtol = 10)
# Ensure that we do not have excessive memory allocations
# (e.g., from type instabilities)
let
Expand Down

0 comments on commit 260782e

Please sign in to comment.