Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test status checks #16

Closed
wants to merge 4 commits into from

Conversation

patrickersing
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ca97ca) 100.00% compared to head (3819890) 75.00%.

Files Patch % Lines
src/TrixiShallowWater.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main      #16       +/-   ##
============================================
- Coverage   100.00%   75.00%   -25.00%     
============================================
  Files            1        1               
  Lines            3        4        +1     
============================================
  Hits             3        3               
- Misses           0        1        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede sloede closed this Jan 16, 2024
@sloede sloede reopened this Jan 16, 2024
@sloede sloede closed this Jan 16, 2024
@sloede sloede reopened this Jan 16, 2024
@sloede
Copy link
Member

sloede commented Jan 16, 2024

I've re-enabled the CI checks to be required, but not (yet) the coveralls check.

@sloede
Copy link
Member

sloede commented Jan 16, 2024

Ha! Just making the coverage/coveralls check required derails the whole thing again:
image

@sloede
Copy link
Member

sloede commented Jan 16, 2024

So, I made coveralls non-required again and instead made codecov required. This seems to work as expected:
image
Maybe we keep it like this for now and move on to other topics 😅

@patrickersing
Copy link
Contributor Author

Nice! This seems to fix our problem, for me it's totally fine to keep it like this.

@andrewwinters5000
Copy link
Member

Maybe we keep it like this for now and move on to other topics 😅

That is okay from my end of things as well. Thanks for your help @sloede !

@patrickersing patrickersing deleted the CI_testing branch January 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants