Fix failing CI tests due to SWE wave speed changes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 45 45
Lines 1680 1680
=======================================
Hits 1667 1667
Misses 13 13 ☔ View full report in Codecov by Sentry. |
andrewwinters5000
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts some elixirs and test reference values to account for the bug fix of
max_abs_speedsfor theShallowWaterEquationsWetDry1DandShallowWaterEquationsWetDry2Din trixi-framework/Trixi.jl#1898I have also added an additional test for
elixir_shallowwater_ec.jlto the upstream tests, since the current upstream tests didn't throw an error for the change in wave speed.ARW edit: You also do this for the 2D equations, so I adjusted the comment for posterity.