Add tests and continuous integration #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiyangc
reviewed
Jan 11, 2019
| @@ -0,0 +1,72 @@ | |||
| pragma solidity ^0.4.23; | |||
There was a problem hiding this comment.
Which contract is using Ownable? We should probably only do tests for the existing contracts, then add contract/test pairs from then on.
There was a problem hiding this comment.
Got it, my idea was to show how to test ownable contracts. No problem.
There was a problem hiding this comment.
Hey @taiyangc, I'm using on BaseCappedTokenMock.sol file, can you take a look, please?
taiyangc
reviewed
Jan 11, 2019
| const TOKEN_UNIT = 1000000 | ||
| const TOKEN_TOTAL_SUPPLY = 20000000000 | ||
| const TOKEN_DECIMALS = 6 | ||
| const INVALID_ADDRESS = '0x0' |
There was a problem hiding this comment.
Is this an older version of test from openzeppelin or written from scratch?
There was a problem hiding this comment.
Hey @taiyangc, this was inherited from openzeppelin indeed, but I had adapted it to work on Tron since it wasn't running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.