Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: fix trpc stream crash at client when connect failed with high frequency #101

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

weimch
Copy link
Contributor

@weimch weimch commented Jan 5, 2024

… frequency

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4147869) 81.76642% compared to head (a92b088) 81.67955%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #101         +/-   ##
===================================================
- Coverage   81.76642%   81.67955%   -0.08687%     
===================================================
  Files            855         855                 
  Lines          33899       33902          +3     
===================================================
- Hits           27718       27691         -27     
- Misses          6181        6211         +30     
Files Coverage Δ
...ream/trpc/trpc_client_stream_connection_handler.cc 96.55172% <100.00000%> (ø)
...tream/trpc/trpc_client_stream_connection_handler.h 94.44444% <ø> (ø)
...r/conn_complex/fiber_tcp_conn_complex_connector.cc 84.07643% <100.00000%> (-0.10080%) ⬇️
trpc/stream/trpc/trpc_client_stream_handler.cc 85.71429% <50.00000%> (-3.75939%) ⬇️
trpc/stream/trpc/trpc_server_stream_handler.cc 86.95652% <50.00000%> (-3.51968%) ⬇️

... and 14 files with indirect coverage changes

@helloopenworld helloopenworld merged commit ffcfe9f into trpc-group:main Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants