This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for putting the PR together. I prefer this behavior to be implemented as a flag to |
Delete output:
Updated help output:
Updated push help output:
|
@thesamet changed to a flag. |
thesamet
suggested changes
Feb 13, 2017
dogpush/dogpush.py
Outdated
parser_push.set_defaults(command=command_init) | ||
|
||
|
||
parser_push = subparsers.add_parser( | ||
'push', help='push monitors to datadog') | ||
'push', help='Push monitors to DataDog.') | ||
parser_push.add_argument('-d', '--delete', action='store_true', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete_untracked
dogpush/dogpush.py
Outdated
for name in changed: | ||
datadog.api.Monitor.update( | ||
remote_monitors[name]['id'], | ||
**_prepare_monitor(local_monitors[name])) | ||
|
||
if args.delete: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too
@nandrienko Reviewed this. Please merge when convenient. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync command is used to sync remote monitor state with local monitor state. This means creating, updating, and deleting monitors as needed.Fixes #8 and, assuming all monitors are tracked in code, #7 as well.