Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated strucutre of main page #396

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Conversation

ChoudharyHarish
Copy link
Collaborator

Updated the file structure of main page

@sayan-truefoundry sayan-truefoundry changed the title updated strucutre of main page chore: updated strucutre of main page Oct 28, 2024
Copy link
Contributor

@Blakeinstein Blakeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i submitted a review as soon as you updated... oh well. I think it would be better to break the page into components for sections and use React Context to avoid prop drilling.

frontend/src/screens/dashboard/docsqa/main/index.tsx Outdated Show resolved Hide resolved
frontend/src/screens/dashboard/docsqa/main/index.tsx Outdated Show resolved Hide resolved
@ChoudharyHarish
Copy link
Collaborator Author

@Blakeinstein Review it now and check if everything is as we discussed in meet or not

Copy link
Contributor

@Blakeinstein Blakeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor changes needed.

@ChoudharyHarish
Copy link
Collaborator Author

@Blakeinstein I made the requested changes review it once.

Blakeinstein
Blakeinstein previously approved these changes Nov 8, 2024
Copy link
Contributor

@Blakeinstein Blakeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please rebase and test that everything works.

frontend/src/screens/dashboard/docsqa/main/context.tsx Outdated Show resolved Hide resolved
@ChoudharyHarish ChoudharyHarish merged commit a3af665 into main Nov 18, 2024
1 check passed
@ChoudharyHarish ChoudharyHarish deleted the strucuture-rewamp branch November 18, 2024 07:25
S1LV3RJ1NX pushed a commit that referenced this pull request Nov 29, 2024
* updated strucutre of main page

* updated the names

* modifed main folder

* removed some variables from context and refined some names

* added different useEffect for each case

* added default model selection

* removed a console log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants