-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated strucutre of main page #396
Conversation
frontend/src/screens/dashboard/docsqa/main/partials/NoAnswer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i submitted a review as soon as you updated... oh well. I think it would be better to break the page into components for sections and use React Context to avoid prop drilling.
@Blakeinstein Review it now and check if everything is as we discussed in meet or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor changes needed.
frontend/src/screens/dashboard/docsqa/main/components/ApplicationModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/screens/dashboard/docsqa/main/components/Right.tsx
Outdated
Show resolved
Hide resolved
@Blakeinstein I made the requested changes review it once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please rebase and test that everything works.
1f6542e
to
9ea3085
Compare
472e309
* updated strucutre of main page * updated the names * modifed main folder * removed some variables from context and refined some names * added different useEffect for each case * added default model selection * removed a console log
Updated the file structure of main page