NAS-133858 / 25.10 / Make sure CPU temperature is reported for virtual cores #15514
+47
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
requested changes
Feb 3, 2025
| core_id = None | ||
|
|
||
| for line in cpu_block.splitlines(): | ||
| if match := RE_PROCESSOR.match(line): |
There was a problem hiding this comment.
No reason to use regex here. Just use if line.startswith('core id')
| core_id = match.group(1) | ||
|
|
||
| # Ensure valid data is collected before adding to mapping | ||
| if processor_id is not None and core_id is not None and processor_id != core_id: |
There was a problem hiding this comment.
Suggested change
| if processor_id is not None and core_id is not None and processor_id != core_id: | |
| if all((processor_id, core_id)) and processor_id != core_id: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the Netdata CPU temperature plugin does not report temperatures for virtual cores.
Solution
Mirror the temperature readings from physical cores to their respective virtual cores, similar to how htop handles it.
Ref: https://unix.stackexchange.com/questions/400605/understanding-core-ids