NAS-134104 / 25.04-RC.1 / Fix netmask being empty string (by Qubad786) #15662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8acdb4c)
Qubad786
approved these changes
Feb 10, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick failed. Please resolve conflicts by running:
If the original PR was merged via a squash, you can just cherry-pick the squashed commit:
Problem
In certain race conditions i.e stopping/crashing a virt instance, it is possible that netmask is an empty string returned by incus which breaks our query logic which in turn breaks consumers of
virt.instance.query.Solution
Gracefully handle the case when netmask is reported as an empty string
Original PR: #15660
Jira URL: https://ixsystems.atlassian.net/browse/NAS-134104