Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-134197 / 25.10 / Set extra="ignore" for CoreSetOptionsOptions #15695

Merged
merged 2 commits into from
Feb 13, 2025
Merged

NAS-134197 / 25.10 / Set extra="ignore" for CoreSetOptionsOptions #15695

merged 2 commits into from
Feb 13, 2025

Conversation

bmeagherix
Copy link
Contributor

Set extra="ignore" for CoreSetOptionsOptions

This enhances a previous change made with the same goal (PR #15682)

@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-134197

@bugclerk bugclerk changed the title Set extra="ignore" for CoreSetOptionsOptions NAS-134197 / 25.10 / Set extra="ignore" for CoreSetOptionsOptions Feb 13, 2025
@truenas truenas deleted a comment from bugclerk Feb 13, 2025
@bmeagherix bmeagherix requested a review from a team February 13, 2025 16:02
themylogin
themylogin requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@themylogin themylogin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the same changes for v25_10_0 please

@bmeagherix bmeagherix merged commit e1dc846 into master Feb 13, 2025
2 checks passed
@bmeagherix bmeagherix deleted the fix_extra branch February 13, 2025 16:16
@bugclerk bugclerk mentioned this pull request Feb 13, 2025
Merged
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@themylogin themylogin themylogin approved these changes

@yocalebo yocalebo yocalebo approved these changes

Assignees
No one assigned
Labels
backport-25.04-RC.1 backported jira no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmeagherix @bugclerk @themylogin @yocalebo