Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elevenlabs analyzer #3850
base: main
Are you sure you want to change the base?
elevenlabs analyzer #3850
Changes from 18 commits
81005b9
794d176
f6c146c
75071f4
f61faf2
759d9c7
de93b9b
1704ba2
3cb54ca
6e2bfaf
0c79411
96dc34b
cb957aa
58f1736
5fd9705
f05f2fa
b36caf3
1937f36
3da2a78
4975781
3fa4402
6fa3a2e
8e3716d
8280b40
dda4747
a2cf1f4
16b8bc1
aeac476
39f50e0
2241037
9b88fb1
a4d9a77
7fac258
31504c1
0f47864
fe99586
703cd0b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Points to Consider for Implementation while getting resource:
Aggregate Errors:
Instead of failing on the first error, collect all errors encountered during the process and return them as a single aggregated error at the end. This ensures that users get a complete picture of what went wrong, rather than having to address issues one at a time.
Graceful Error Handling in CLI:
For the CLI, log errors when checking a specific scope or fetching resource fails, but continue processing other tasks. Improving the user experience and allowing for partial success.
Concurrent API Calls:
Use Go routines to call APIs concurrently. This will significantly improve performance by reducing the total time spent waiting for API responses.
Let me know your thoughts on these points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My vote will be for concurrent API calls with error handling for each permission.