[Feat] implementation Notion analyzer #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
approved these changes
Feb 7, 2025
|
Conflicts need to be resolved! |
relationship of resources and permission modified.
updated the expected json for test.
abmussani
force-pushed
the
notion-analyzer-impl
branch
from
41bf0a4 to
540c2de
Compare
ahrav
approved these changes
Feb 8, 2025
Thanks @ahrav for thoroughly reviewing the PR. I have incorporated your comments. |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since
Notion.coallows to enable capabilities against integration token, It is a good candidate to build an analyzer for it.This PR implements notion analyzer along with its integration test.
Checklist:
make test-community)?make lintthis requires golangci-lint)?