feat: make ipecharts compatible with notebook<7 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungleduc
requested changes
Feb 7, 2025
|
I fixed the issue with the CI, please rebase your branch to get the patch. |
Co-authored-by: Duc Trung Le <[email protected]>
iisakkirotko
force-pushed
the
feat-nbextension
branch
from
15007d4 to
8eed818
Compare
iisakkirotko
force-pushed
the
feat-nbextension
branch
from
d0f356f to
2386864
Compare
trungleduc
requested changes
Feb 8, 2025
Previously we only built the extension once into `ipecharts/nbextension`, but we also want the nbextension code to be available on CDN, so we also build into `dist` and include that in the package.
trungleduc
approved these changes
Feb 8, 2025
|
Thanks! |
|
Released in 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for notebook versions below 7. Should enable for ipecharts to work in Solara. VSCode support might be possible as well, if you're up to publishing the bundle on to unpkg @trungleduc.
Fixes #25