Enable Ci Debugger in bazel action #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-trunk-io
force-pushed
the
pat/AddCiDebugger
branch
from
a6826b4 to
ebc8e34
Compare
TylerJang27
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
See one note. Also we can close this out https://linear.app/trunk/issue/TRUNK-10103/add-ci-debugger-support-to-bazel-action
action.yaml
Outdated
| uses: trunk-io/breakpoint@v1 | ||
| with: | ||
| breakpoint-id: ${{ inputs.trunk-ci-debugger-breakpoint-name }} | ||
| trunk-token: ${{ env.TRUNK_TOKEN }} |
There was a problem hiding this comment.
Don't we usually specify to use this from secrets.?
There was a problem hiding this comment.
Yes, but an action can't access secrets from the og repo, maybe I'll just add it as in input
There was a problem hiding this comment.
Actually completely missed that the action already takes a token as an input, modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.