Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI Debugger #22

Merged
merged 2 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/compute_impacted_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,8 @@ jobs:

- name: Compute Impacted Targets
id: compute
uses: trunk-io/[email protected]
with:
breakpoint-id: trunk-bazel-action
run: ./src/scripts/compute_impacted_targets.sh
trunk-token: ${{ secrets.TRUNK_DEBUGGER_TOKEN }}
org: trunk-staging-org
shell: bash
run: ./src/scripts/compute_impacted_targets.sh
shell: bash
env:
MERGE_INSTANCE_BRANCH: do_not_delete/stable_test_branch
MERGE_INSTANCE_BRANCH_HEAD_SHA: 3e8b2a57e0f3ad7b63cc487eae576c25b84b653b
Expand All @@ -47,7 +42,6 @@ jobs:
BAZEL_PATH: bazel
BAZEL_DIFF_CMD: ${{ steps.bazel-diff.outputs.bazel_diff_cmd }}
BAZEL_DIFF_COMMAND_OPTIONS: --remote_cache=
TRUNK_API_ADDRESS: api.trunk-staging.io:8443

- name: Validate Impacted Targets Computation
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
uses: actions/checkout@v3

- name: Install pnpm
uses: pnpm/action-setup@d882d12c64e032187b2edb46d3a0d003b7a43598
uses: pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b
with:
version: 8.6.7

Expand Down
33 changes: 1 addition & 32 deletions action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,6 @@ inputs:
test-negative-tag-filter:
description: Negative tag filter to apply to impacted targets
required: false
enable-trunk-ci-debugger:
description: Enable support for the Trunk ci debugger (https://docs.trunk.io/ci-debugger)
required: false
default: false
trunk-ci-debugger-breakpoint-name:
description: Name of the trunk breakpoint to apply
required: false
default: my-breakpoint

runs:
using: composite
Expand Down Expand Up @@ -179,7 +171,7 @@ runs:
BAZEL_STARTUP_OPTIONS: ${{ inputs.bazel-startup-options }}

- name: Test Impacted Targets
if: inputs.test-targets == 'true' && !inputs.enable-trunk-ci-debugger
if: inputs.test-targets == 'true'
id: test-impacted-targets
run: ${GITHUB_ACTION_PATH}/src/scripts/test_impacted_targets.sh
working-directory: ${{ steps.prerequisites.outputs.workspace_path }}
Expand All @@ -196,26 +188,3 @@ runs:
BAZEL_NEGATIVE_SCOPE_FILTER: ${{ inputs.test-negative-scope-filter }}
BAZEL_NEGATIVE_TAG_FILTER: ${{ inputs.test-negative-tag-filter }}
CI: "true"

- name: Test Impacted Targets (with debugger)
if: inputs.test-targets == 'true' && inputs.enable-trunk-ci-debugger
id: test-impacted-targets-dbg
uses: trunk-io/breakpoint@v1
with:
breakpoint-id: ${{ inputs.trunk-ci-debugger-breakpoint-name }}
trunk-token: ${{ inputs.trunk-token }}
run: ${{ github.action_path }}/src/scripts/test_impacted_targets.sh
working-directory: ${{ steps.prerequisites.outputs.workspace_path }}
shell: bash
env:
IMPACTED_TARGETS_FILE:
${{ steps.compute-impacted-targets-test.outputs.impacted_targets_out }}
BAZEL_PATH: ${{ inputs.bazel-path }}
BAZEL_TEST_COMMAND: ${{ inputs.bazel-test-command }}
BAZEL_STARTUP_OPTIONS: ${{ inputs.bazel-startup-options }}
BAZEL_KIND_FILTER: ${{ inputs.test-kind-filter }}
BAZEL_SCOPE_FILTER: ${{ inputs.test-scope-filter }}
BAZEL_NEGATIVE_KIND_FILTER: ${{ inputs.test-negative-kind-filter }}
BAZEL_NEGATIVE_SCOPE_FILTER: ${{ inputs.test-negative-scope-filter }}
BAZEL_NEGATIVE_TAG_FILTER: ${{ inputs.test-negative-tag-filter }}
CI: "true"
Loading