Skip to content

Commit

Permalink
Add warning when config is invalid or not covering any files (#46)
Browse files Browse the repository at this point in the history
1. Add warnings when the neveredit rule is not configured properly .
mostly when it's not checking for anything but you think it should be
2. Updated tool to only emit config issues when checking current (and
not the upstream) - allows it to effectively bypass HTL for config
issues.
3. Update some deps for security reasons
  • Loading branch information
EliSchleifer authored Aug 30, 2024
1 parent 405849c commit 43c64df
Show file tree
Hide file tree
Showing 9 changed files with 283 additions and 235 deletions.
4 changes: 2 additions & 2 deletions .config/toolbox.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ enabled = false
enabled = false

[neveredit]
enabled = true
paths = [] # paths to protect from modification
enabled = false
paths = []
4 changes: 2 additions & 2 deletions .trunk/trunk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,13 @@ lint:
files: [ALL]
commands:
- name: lint
run: ${workspace}/toolbox-latest --upstream=${upstream-ref} --results=${tmpfile} ${target}
run: ${workspace}/toolbox-latest --upstream=${upstream-ref} --cache-dir=${cachedir} --results=${tmpfile} ${target}
output: sarif
batch: true
success_codes: [0]
read_output_from: tmp_file
disable_upstream: false
direct_configs: [toolbox.toml]
version_command:
parse_regex: ${semver}
run: trunk-toolbox --version
Expand All @@ -49,7 +50,6 @@ lint:
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
Expand Down
Loading

0 comments on commit 43c64df

Please sign in to comment.